Updated from new MyFormType() to MyFormType::class
#9765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a new instance of the form type gave me this error: > Type error: Argument 1 passed to Symfony\Component\Form\Extension\Core\EventListener\ResizeFormListener::__construct() must be of the type string, object given
|
Hi @ThomasLandauer, you're right about this, but in |
javiereguiluz
approved these changes
May 14, 2018
xabbuh
added a commit
that referenced
this pull request
May 14, 2018
…homasLandauer) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #9765). Discussion ---------- Updated from `new MyFormType()` to `MyFormType::class` Passing a new instance of the form type gave me this error: > Type error: Argument 1 passed to Symfony\Component\Form\Extension\Core\EventListener\ResizeFormListener::__construct() must be of the type string, object given <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- b031b97 Updated from `new MyFormType()` to `MyFormType::class`
|
In fact, the ability to pass forms by the FQCN instead of form type instances was introduced in 2.8 and is required since 3.0. I have merged your PR into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a new instance of the form type gave me this error: